[Octave-bug-tracker] [bug #58144] "Cdata" icon for UIcontrol is incorrectly sized

[Rik]

Follow-up Comment #14, bug #58144 (project octave):

I don't know which way is better, but changing clipping to 24x24 from 32x32 is
technically quite easy.  I've attached a patch which does that.


diff -r 49384057fb03 libgui/graphics/ToolBarButton.cc
--- a/libgui/graphics/ToolBarButton.cc  Mon Apr 20 08:28:22 2020 -0700
+++ b/libgui/graphics/ToolBarButton.cc  Mon Apr 20 10:03:28 2020 -0700
@@ -49,7 +49,7 @@ namespace QtHandles
     action->setVisible (tp.is_visible ());
 
     // Get the icon data from cdata or as a named icon
-    QImage img = Utils::makeImageFromCData (tp.get_cdata (), 32, 32);
+    QImage img = Utils::makeImageFromCData (tp.get_cdata (), 24, 24);
 
     if (img.width () == 0)
       {
@@ -104,7 +104,7 @@ namespace QtHandles
       case T::properties::ID_CDATA:
         {
           // Get the icon data from cdata or as a named icon
-          QImage img = Utils::makeImageFromCData (tp.get_cdata (), 32, 32);
+          QImage img = Utils::makeImageFromCData (tp.get_cdata (), 24, 24);
 
           if (img.width () == 0)
             {


The visual difference is shown in the attached file
Octave_24x24_clipping.png.



(file #48886, file #48887)
    _______________________________________________________

Additional Item Attachment:

File name: ToolBarButton.24x24.patch      Size:0 KB
    <https://savannah.gnu.org/file/ToolBarButton.24x24.patch?file_id=48886>

File name: Octave_24x24_clipping.png      Size:16 KB
    <https://savannah.gnu.org/file/Octave_24x24_clipping.png?file_id=48887>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?58144>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/