octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #57033] Replace CXSPARSE with SPQR


From: Markus Mützel
Subject: [Octave-bug-tracker] [bug #57033] Replace CXSPARSE with SPQR
Date: Wed, 6 Jan 2021 18:38:38 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36 Edg/87.0.664.66

Follow-up Comment #44, bug #57033 (project octave):

The attached patch adds more checks on converting between different integer
types and uses the necessary integer pointer types.

I'm unsure where to add the new function `from_size_t` and whether that is a
good name for a function that checks whether the input can be safely converted
from `size_t` to `octave_idx_type`.
The function `from_suitesparse_long` is probably in the correct file
(oct-sparse.h). But same doubt about the name.

Compiles for me with gcc on Ubuntu, and the test suite passes.
I haven't tested if this would fix building for the Win32 target.

(file #50671)
    _______________________________________________________

Additional Item Attachment:

File name: bug57033_integer_types.patch   Size:26 KB
   
<https://file.savannah.gnu.org/file/bug57033_integer_types.patch?file_id=50671>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57033>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]