[Octave-bug-tracker] [bug #57033] Replace CXSPARSE with SPQR

[Markus Mützel]

Update of bug #57033 (project octave):

                  Status:         Patch Submitted => Ready For Test         

    _______________________________________________________

Follow-up Comment #36:

Re comment #32: Some member functions of the sparse_qr_rep class don't have
implementations with SPQR (only with CXSPARSE). I don't know if it's
principally impossible to replace those implementations using SPQR or if this
just isn't done yet.
For a test, I marked all tests that are conditional on HAVE_CXSPARSE in qr.cc
with the runtime condition you propose, configured with `--without-cxsparse`
and ran the test suite.
This also revealed some other issues. (I'll probably push a separate patch
and/or open a new report for those.)
All of the BISTs in qr.cc however still passed. I guess that either those
member functions aren't used (and could be removed?) or we just don't have
BISTs for them.
Anyway, I opted to adopt the solution you proposed.

Re comment #33: I guess that is settled then. :-)

Re comment #34: I don't know how different distributions organize and install
the SuiteSparse headers. Just looking at how we test for the other SuiteSparse
library headers, it looks like we should check other locations, too. But I
guess, it would also be ok to wait for complaints.

Re comment #35: I'll leave that for follow up changes.

The patch still isn't perfect. But imho, it is a big improvement compared to
what we have currently. So, I pushed it here:
https://hg.savannah.gnu.org/hgweb/octave/rev/66f162b6fa03

Thanks again to Simon Hau who did the hard lifting with the initial
implementation.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57033>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/