[Octave-bug-tracker] [bug #57033] Replace CXSPARSE with SPQR

[Markus Mützel]

Follow-up Comment #30, bug #57033 (project octave):

I believe I finally found the reason for the crashes: There was a double free
of the cholmod_common object in some of the member functions and the
sparse_qr_rep class destructor.
After fixing that, the test suite and the commands from comment #16 no longer
cause a crash.

I rebased the patch to the current tip, cleaned it up a bit more and added the
API tags.

The following issues are still open:
- BISTs are duplicated for HAVE_CXSPARSE and HAVE_SPQR.
- A better configure check is needed that checks for the templated function
`SuiteSparseQR_min2norm<double>` (instead of checking for the function
`SuiteSparseQR_C`).
- Should we check for the header in more locations (e.g. SuiteSparseQR.hpp,
ufsparse/SuiteSparseQR.hpp, spqr/SuiteSparseQR.hpp, ...)?
- I'm not sure if an array dimension can ever be negative. Maybe the
respective error messages should be re-worded.
- It feels a little bit like the private static member function
`min2norm_solve` isn't really a member function of the `sparse_qr`. Instead,
its implementation is completely independent of that class. I'm not sure if it
should be a member of that class or a standalone function. But maybe that is
the nature of a static member function...

Anyway, attached is a new version of the patch.

(file #50648)
    _______________________________________________________

Additional Item Attachment:

File name: bug57033_spqr_rev7.patch       Size:77 KB
   
<https://file.savannah.gnu.org/file/bug57033_spqr_rev7.patch?file_id=50648>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57033>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/