[Octave-bug-tracker] [bug #61199] Allow 'char' input sets to nchoosek for Matlab compatibility

[Nicholas Jankowski]

Follow-up Comment #13, bug #61199 (project octave):

as a coauthor of repelem... i don't think I even knew struct arrays were a
thing back then.

looking at repelem input description:

Input array, specified as a matrix or multidimensional array.

Data Types: single | double | int8 | int16 | int32 | int64 | uint8 | uint16 |
uint32 | uint64 | logical | char | struct | table | cell | datetime |
duration
Complex Number Support: Yes


i guess that could maybe be a separate incompatibility report. 

looking at the same input description for nchoosek:

set of all choices, specified as a vector.

Example: [1 2 3 4 5]

Example: [1+1i 2+1i 3+1i 4+1i]

Example: int16([1 2 3 4 5])

Example: [true false true false]

Example: ['abcd']

Data Types: single | double | int8 | int16 | int32 | int64 | uint8 | uint16 |
uint32 | uint64 | logical | char
Complex Number Support: Yes


no mention of either cells or structs (or strings either), so this seems to
fall under chasing completely undocumented matlab?  That said, the output
rules do seem fairly consistent and 'input class agnostic'


assuming repelem was expanded for struct arrays, should that more or less
cover the cases? maybe put those in as  xtests pending that change?

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61199>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/