octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #61760] [octave forge] (image) imresize - anti


From: Hartmut
Subject: [Octave-bug-tracker] [bug #61760] [octave forge] (image) imresize - antialiasing is not implemented
Date: Thu, 17 Feb 2022 14:01:38 -0500 (EST)

Follow-up Comment #14, bug #61760 (project octave):

I have eventually had a look at the patch (comment #11 plus interp_method from
comment #4), sorry for the delay. This looks like a good piece of code to me.
Thanks a lot for generating this @Christof. I would be happy to see this
pushed to the image repo soon.

Just for completeness some things I've looked at:

* There is a new feature "custom kernel", it also has a new test added.
* There is a new method "box", it also has a new test added.
* There is the new feature "anti-aliasing", it also has some tests.
* All old and new BIST tests pass, also when running them 100 times in a row.
* The help text is improved a lot and also covers those new features.
* Coding style seems to be mostly followed.
* The core algorithm now moved away from calling the function imremap.m. It
now uses a ".*" multiplication with a kernel matrix.

Some minor details I would suggest:
* @Christof: I think it would be alright to add your name at the top of the
file "imresize.m" because you changed the core algorithm here. Please feel
free to do this!
* Please add a longer commit message, when pushing this to the repo.
* Please mention it shortly in the NEWS file.
* Please have a short look if the use of the image package function "imcast.m"
could make this code shorter or easier to read. (I am unsure if it would.)
Otherwise it is fine like it is now, as well.

Now the function "imperspectivewarp.m" is the only function left, that still
uses our Octave-only "imremap.m".

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61760>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]