[Octave-bug-tracker] [bug #61994] Crash on GUI exiting with octave_base_value objects still open.

[John W. Eaton]

Follow-up Comment #35, bug #61994 (project octave):

After writing comment #33, I tried some other things and was able to duplicate
the crash in the buildbot build tree for the mxe-octave-native-all
configuration and I was able to get a core file to examine with gdb and it
looked like the crash was happening when deleting the static
dynamic_library::dynlib_rep::s_instances object.  The attached diff removes
that object entirely and avoids the crash for me.

It seems the intent of the s_instances static data member was to avoid
reloading libraries if there were still references to functions from a
previously loaded library of the same name?  In the past maybe reloading
forced the library to be closed?  But I don't see that it would happen now. 
I'm also wondering now whether we need any of the complication in the
dynamic_library class of trying track what functions have been loaded from the
file and whether the file is out of date, etc.  Maybe now it can just be a
wrapper to provide a consistent interface to the underlying dlopen/LoadLibrary
functions?

But since this change is getting to be fairly significant, I'm also fine with
undoing my previous change for version 7 and making the more substantial
changes on default where we can do more testing.  I backed out the previous
change here:

http://hg.savannah.gnu.org/hgweb/octave/rev/db0335e1b6e0

(file #52892)
    _______________________________________________________

Additional Item Attachment:

File name: dynamic-library-instances-diffs.txt Size:3 KB
   
<https://file.savannah.gnu.org/file/dynamic-library-instances-diffs.txt?file_id=52892>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61994>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/