[Octave-bug-tracker] [bug #63803] Saving causes OOM, crash, and loss of already saved data

[John W. Eaton]

Follow-up Comment #3, bug #63803 (project octave):

I don't see a crash, but the system I ran it on has 128GB of memory.

You probably want to look at octave_bool_matrix::save_binary in
ov-bool-mat.cc.  I don't remember for sure now, but I suspect the reason that
there is a copy of the data to a local buffer there is so that the only values
written are 1 and 0 in case the compiler might store some other values for
bool TRUE/FALSE.  That's very old code, from what I can tell.  It may not be
needed now if there is a guarantee about the values of bool TRUE/FALSE in
standard C++ that was not present way back in the olden times.  Even if we do
need to ensure 1/0 values, we could do this with a loop over a smaller
temporary buffer size.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63803>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/