[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

cleaned up VLS support

From: Ben Pfaff
Subject: cleaned up VLS support
Date: Sat, 06 May 2006 19:30:50 -0700
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)

I happened to be looking at my pspp-cvs folder just when your
commit happened.  Thanks for reworking that.  It looks much
better.  I do have a couple of additional comments:

        * Now width_to_bytes() is only used in the
          sys-file-reader/writer, could it be moved into one of
          those files (or create a new one for common code)?

        * compare_var_shortnames() and hash_var_shortname() are
          complex, but I don't understand why they can't just
          call, respectively, strcmp() and hsh_hash_string().  Is
          something tricky going on?

"Implementation details are beyond the scope of the Java virtual
 machine specification.  One should not assume that every virtual
 machine implementation contains a giant squid."
--"Mr. Bunny's Big Cup o' Java"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]