[patch #5583] NPAR TESTS

[Ben Pfaff]

Follow-up Comment #1, patch #5583 (project pspp):

Have you checked out the algorithms described on spss.com against what SPSS
Statistical Algorithms says?  The latter might be dated; who knows.

In value_dup, I'd prefer to calculate the size as MIN(width, sizeof *val).

In compare_var_index, please use less-than and greater-than to figure out the
comparison result; if we ever change the `index' member to an unsigned type
(which would make a lot of sense), we'll really appreciate not having to hunt
down this bug.

I didn't look very closely at the new files you introduced.  I'll assume that
they do the right thing.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?5583>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/