[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch #5583] NPAR TESTS

From: John Darrington
Subject: Re: [patch #5583] NPAR TESTS
Date: Sat, 25 Nov 2006 10:34:05 +0800
User-agent: Mutt/1.5.4i

On Sat, Nov 25, 2006 at 01:36:39AM +0000, Ben Pfaff wrote:
     Follow-up Comment #1, patch #5583 (project pspp):
     Have you checked out the algorithms described on against what SPSS
     Statistical Algorithms says?  The latter might be dated; who

I was actually refering to the pages downloaded from  So far
as I'm aware, they are identical to those from SPSS Statistical
Algorithms.  I'll check the copy in the UWA library next week to make

     In value_dup, I'd prefer to calculate the size as MIN(width,
     sizeof *val).

This would give the wrong answer, since if width is zero, then the
size should be 8.
     In compare_var_index, please use less-than and greater-than to figure out 
     comparison result; if we ever change the `index' member to an unsigned type
     (which would make a lot of sense), we'll really appreciate not having to 
     down this bug.

     I didn't look very closely at the new files you introduced.  I'll assume 
     they do the right thing.

"Right thing" is somewhat subjective.  But I thought about it fairly
carefully.  I think it'll make it easy to add new subcommands to NPAR
TEST, at least from the parsing point of view.   It also fits in with
a general idea I have to seperate the parsing of commands from their
execution, which I'll talk about later. 


PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See or any PGP keyserver for public key.

Attachment: pgp_XS3aUe12t.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]