[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Simpler-Proc GUI patch

From: John Darrington
Subject: Re: Simpler-Proc GUI patch
Date: Tue, 29 May 2007 08:35:17 +0800
User-agent: Mutt/1.5.13 (2006-08-11)

I've checked in this change, with Ben's suggestion.  The GUI now seems
to be basically functional and it appears to be faster when scrolling
through very large data files (as we'd expected --- thanks Ben).
There are still some funny things happening when the data sheet in
certain cases, but it's no worse than before.

I suggest that the time is now right to start merging this branch back
into the trunk.  Then perhaps I can look at all the things that are
wrong with the GtkSheet stuff and fix them.


On Thu, May 24, 2007 at 08:37:39PM -0700, Ben Pfaff wrote:
     I can see that there was a bug here, now that you draw attention
     to it: if casereader_read indirectly reads case_cnt while it is
     still changing, then it could cause some confusion.  But one of
     the constraints on casereader implementations is that, once the
     number of cases is known, it can never change (barring I/O
     error).  Thus, I'd change the "return n_cases;" line here to
     "reader->case_cnt = n_cases;" so that the case count is cached
     for later.  If that introduces a problem, then there's probably
     something wrong elsewhere.

PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See or any PGP keyserver for public key.

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]