Re: Failing tests.

[Ben Pfaff]

On Tue, Jan 01, 2013 at 09:22:37AM -0800, Ben Pfaff wrote:
> On Tue, Jan 01, 2013 at 04:46:51PM +0100, John Darrington wrote:
> > This commit:
> > 
> > commit d49a471a1fa405dd68d51ade4a4fed35b77cc41d
> > Author: Ben Pfaff <address@hidden>
> > Date:   Thu Dec 27 21:17:43 2012 -0800
> > 
> >     csv-file-writer: Fix implementation of decimal point option.
> >     
> >     Now that pspp sets LC_NUMERIC, dtoastr() might yield either '.' or ',' 
> > as
> >     the decimal point, so the CSV writer needs to check for either one and
> >     replace it by the decimal point requested by the caller.
> >     
> >     Reported by John Darrington.
> > 
> > seems to have broken tests 295 and 296.
> 
> That's odd, the tests run fine in my normal build directory.  But I see
> that they're failing in the nightly builds.  I'll figure it out.

I pushed the following fix.

--8<--------------------------cut here-------------------------->8--

From: Ben Pfaff <address@hidden>
Date: Tue, 1 Jan 2013 22:06:59 -0800
Subject: [PATCH] expressions: Fix dependency on current year in tests.

The tests for expressions broke on Jan 1, 2013 because the default epoch
depends on the current year.  This commit fixes the tests by setting a
fixed epoch for dates.

Reported by John Darrington.
---
 tests/language/expressions/evaluate.at |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/language/expressions/evaluate.at 
b/tests/language/expressions/evaluate.at
index 4512458..cd514fe 100644
--- a/tests/language/expressions/evaluate.at
+++ b/tests/language/expressions/evaluate.at
@@ -3,12 +3,13 @@ m4_define([CHECK_EXPR_EVAL],
    AT_DATA([evaluate.sps],
      [set mxwarn 1000.
 set mxerr 1000.
+set epoch 1940.
 m4_foreach([check], [m4_shift($@)],
                  [DEBUG EVALUATE NOOPT m4_argn(4, check)/[]m4_car(check).
 DEBUG EVALUATE m4_argn(4, check)/[]m4_car(check).
 ])])
    AT_CAPTURE_FILE([evaluate.sps])
-   m4_pushdef([i], [2])
+   m4_pushdef([i], [3])
    AT_CHECK([pspp --testing-mode --error-file=- --no-output evaluate.sps], 
      [m4_if(m4_bregexp([m4_foreach([check], [m4_shift($@)], [m4_argn(3, 
check)])], [error:]), [-1], [0], [1])], 
      [stdout])
-- 
1.7.10.4