[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch for review

From: John Darrington
Subject: Re: Patch for review
Date: Fri, 24 May 2013 16:17:49 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

It would certainly make sense to follow what the Gtk devs are doing where 
However that patch we can't apply to master, because it uses a function which
does not exist in Gtk2.16 which is what we depend upon.

I'll think about starting a Gtk3-transition branch and apply it to that.


On Mon, May 20, 2013 at 08:10:33PM -0700, Ben Pfaff wrote:
     On Mon, May 20, 2013 at 07:33:19AM +0200, John Darrington wrote:
     > A small patch - I think it is safe.  But a second opinion would be
     > appreciated.
     It looks OK at first glance.  But here is the corresponding patch from
     the GTK+ repository that makes the same change to GtkTreeView.  It might
     be better to adapt that change to PsppSheetView.
     --8<--------------------------cut here-------------------------->8--
     From: Emmanuele Bassi <address@hidden>
     Date: Mon, 12 Apr 2010 14:54:41 +0100
     Subject: [PATCH] tree-view: Use gtk_widget_send_focus_change()
     Remove the second (and last) internal user of the GTK_HAS_FOCUS flag.
      gtk/gtktreeview.c |   16 +++-------------
      1 file changed, 3 insertions(+), 13 deletions(-)
     diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c
     index 93bb688..f464ec4 100644
     --- a/gtk/gtktreeview.c
     +++ b/gtk/gtktreeview.c
     @@ -10268,22 +10268,12 @@ send_focus_change (GtkWidget *widget,
        GdkEvent *fevent = gdk_event_new (GDK_FOCUS_CHANGE);
     -  g_object_ref (widget);
     - if (in)
     -  else
        fevent->focus_change.type = GDK_FOCUS_CHANGE;
     -  fevent->focus_change.window = g_object_ref (widget->window);
     +  fevent->focus_change.window = g_object_ref (gtk_widget_get_window 
        fevent-> = in;
     -  gtk_widget_event (widget, fevent);
     -  g_object_notify (G_OBJECT (widget), "has-focus");
     -  g_object_unref (widget);
     +  gtk_widget_send_focus_change (widget, fevent);
        gdk_event_free (fevent);

PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See or any PGP keyserver for public key.

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]