[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 07/17] hw/block/nvme: fix endian conversion
From: |
Klaus Jensen |
Subject: |
[PATCH v3 07/17] hw/block/nvme: fix endian conversion |
Date: |
Tue, 22 Sep 2020 10:45:23 +0200 |
From: Klaus Jensen <k.jensen@samsung.com>
The raw NLB field is a 16 bit value, so use le16_to_cpu instead of
le32_to_cpu and cast to uint32_t before incrementing the value to not
wrap around.
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/block/nvme.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 25b34b3701db..638e3b1ccac8 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -645,7 +645,7 @@ static uint16_t nvme_write_zeroes(NvmeCtrl *n, NvmeRequest
*req)
NvmeRwCmd *rw = (NvmeRwCmd *)&req->cmd;
NvmeNamespace *ns = req->ns;
uint64_t slba = le64_to_cpu(rw->slba);
- uint32_t nlb = le16_to_cpu(rw->nlb) + 1;
+ uint32_t nlb = (uint32_t)le16_to_cpu(rw->nlb) + 1;
uint64_t offset = nvme_l2b(ns, slba);
uint32_t count = nvme_l2b(ns, nlb);
uint16_t status;
@@ -669,7 +669,7 @@ static uint16_t nvme_rw(NvmeCtrl *n, NvmeRequest *req)
{
NvmeRwCmd *rw = (NvmeRwCmd *)&req->cmd;
NvmeNamespace *ns = req->ns;
- uint32_t nlb = le32_to_cpu(rw->nlb) + 1;
+ uint32_t nlb = (uint32_t)le16_to_cpu(rw->nlb) + 1;
uint64_t slba = le64_to_cpu(rw->slba);
uint64_t data_size = nvme_l2b(ns, nlb);
--
2.28.0
- [PATCH v3 00/17] hw/block/nvme: multiple namespaces support, Klaus Jensen, 2020/09/22
- [PATCH v3 05/17] hw/block/nvme: alignment style fixes, Klaus Jensen, 2020/09/22
- [PATCH v3 02/17] pci: pass along the return value of dma_memory_rw, Klaus Jensen, 2020/09/22
- [PATCH v3 04/17] hw/block/nvme: commonize nvme_rw error handling, Klaus Jensen, 2020/09/22
- [PATCH v3 01/17] hw/block/nvme: fix typo in trace event, Klaus Jensen, 2020/09/22
- [PATCH v3 06/17] hw/block/nvme: add a lba to bytes helper, Klaus Jensen, 2020/09/22
- [PATCH v3 08/17] hw/block/nvme: add symbolic command name to trace events, Klaus Jensen, 2020/09/22
- [PATCH v3 10/17] hw/block/nvme: default request status to success, Klaus Jensen, 2020/09/22
- [PATCH v3 03/17] hw/block/nvme: handle dma errors, Klaus Jensen, 2020/09/22
- [PATCH v3 07/17] hw/block/nvme: fix endian conversion,
Klaus Jensen <=
- [PATCH v3 09/17] hw/block/nvme: refactor aio submission, Klaus Jensen, 2020/09/22
- [PATCH v3 11/17] hw/block/nvme: harden cmb access, Klaus Jensen, 2020/09/22
- [PATCH v3 12/17] hw/block/nvme: add support for scatter gather lists, Klaus Jensen, 2020/09/22
- [PATCH v3 14/17] hw/block/nvme: refactor identify active namespace id list, Klaus Jensen, 2020/09/22
- [PATCH v3 13/17] hw/block/nvme: add support for sgl bit bucket descriptor, Klaus Jensen, 2020/09/22
- [PATCH v3 16/17] pci: allocate pci id for nvme, Klaus Jensen, 2020/09/22
- [PATCH v3 15/17] hw/block/nvme: support multiple namespaces, Klaus Jensen, 2020/09/22
- [PATCH v3 17/17] hw/block/nvme: change controller pci id, Klaus Jensen, 2020/09/22
- Re: [PATCH v3 00/17] hw/block/nvme: multiple namespaces support, Keith Busch, 2020/09/22