[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 14/17] hw/block/nvme: refactor identify active namespace id li
From: |
Klaus Jensen |
Subject: |
[PATCH v3 14/17] hw/block/nvme: refactor identify active namespace id list |
Date: |
Tue, 22 Sep 2020 10:45:30 +0200 |
From: Klaus Jensen <k.jensen@samsung.com>
Prepare to support inactive namespaces.
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
---
hw/block/nvme.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 1fdd5c9c5ab0..f61076178a6d 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1473,7 +1473,7 @@ static uint16_t nvme_identify_nslist(NvmeCtrl *n,
NvmeRequest *req)
uint32_t min_nsid = le32_to_cpu(c->nsid);
uint32_t *list;
uint16_t ret;
- int i, j = 0;
+ int j = 0;
trace_pci_nvme_identify_nslist(min_nsid);
@@ -1488,11 +1488,11 @@ static uint16_t nvme_identify_nslist(NvmeCtrl *n,
NvmeRequest *req)
}
list = g_malloc0(data_len);
- for (i = 0; i < n->num_namespaces; i++) {
- if (i < min_nsid) {
+ for (int i = 1; i <= n->num_namespaces; i++) {
+ if (i <= min_nsid) {
continue;
}
- list[j++] = cpu_to_le32(i + 1);
+ list[j++] = cpu_to_le32(i);
if (j == data_len / sizeof(uint32_t)) {
break;
}
--
2.28.0
- [PATCH v3 04/17] hw/block/nvme: commonize nvme_rw error handling, (continued)
- [PATCH v3 04/17] hw/block/nvme: commonize nvme_rw error handling, Klaus Jensen, 2020/09/22
- [PATCH v3 01/17] hw/block/nvme: fix typo in trace event, Klaus Jensen, 2020/09/22
- [PATCH v3 06/17] hw/block/nvme: add a lba to bytes helper, Klaus Jensen, 2020/09/22
- [PATCH v3 08/17] hw/block/nvme: add symbolic command name to trace events, Klaus Jensen, 2020/09/22
- [PATCH v3 10/17] hw/block/nvme: default request status to success, Klaus Jensen, 2020/09/22
- [PATCH v3 03/17] hw/block/nvme: handle dma errors, Klaus Jensen, 2020/09/22
- [PATCH v3 07/17] hw/block/nvme: fix endian conversion, Klaus Jensen, 2020/09/22
- [PATCH v3 09/17] hw/block/nvme: refactor aio submission, Klaus Jensen, 2020/09/22
- [PATCH v3 11/17] hw/block/nvme: harden cmb access, Klaus Jensen, 2020/09/22
- [PATCH v3 12/17] hw/block/nvme: add support for scatter gather lists, Klaus Jensen, 2020/09/22
- [PATCH v3 14/17] hw/block/nvme: refactor identify active namespace id list,
Klaus Jensen <=
- [PATCH v3 13/17] hw/block/nvme: add support for sgl bit bucket descriptor, Klaus Jensen, 2020/09/22
- [PATCH v3 16/17] pci: allocate pci id for nvme, Klaus Jensen, 2020/09/22
- [PATCH v3 15/17] hw/block/nvme: support multiple namespaces, Klaus Jensen, 2020/09/22
- [PATCH v3 17/17] hw/block/nvme: change controller pci id, Klaus Jensen, 2020/09/22
- Re: [PATCH v3 00/17] hw/block/nvme: multiple namespaces support, Keith Busch, 2020/09/22
- Re: [PATCH v3 00/17] hw/block/nvme: multiple namespaces support, Klaus Jensen, 2020/09/23