[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/15] tcg/arm: Implement tcg_out_mov for vector types
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 04/15] tcg/arm: Implement tcg_out_mov for vector types |
Date: |
Mon, 8 Feb 2021 18:02:07 +0000 |
On Mon, 8 Feb 2021 at 03:38, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/arm/tcg-target.c.inc | 50 +++++++++++++++++++++++++++++++++++-----
> 1 file changed, 44 insertions(+), 6 deletions(-)
>
> diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc
> index ca9a71ca64..20088ac61a 100644
> --- a/tcg/arm/tcg-target.c.inc
> +++ b/tcg/arm/tcg-target.c.inc
> @@ -178,6 +178,7 @@ typedef enum {
>
> INSN_VLD1 = 0xf4200000, /* VLD1 (multiple single elements) */
> INSN_VST1 = 0xf4000000, /* VST1 (multiple single elements) */
> + INSN_VMOV = 0xf2200110, /* VMOV (register) */
This is VORR, really, and given that you use it with 2 input operands:
> + tcg_out_vreg3(s, INSN_VMOV, type - TCG_TYPE_V64, 0, ret, arg, arg);
I think you might as well call it INSN_VORR (perhaps with a comment
at point-of-use that VORR is the standard way to do a VMOV.)
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v2 01/15] tcg: Change parameters for tcg_target_const_match, (continued)
[PATCH v2 03/15] tcg/arm: Implement tcg_out_ld/st for vector types, Richard Henderson, 2021/02/07
[PATCH v2 04/15] tcg/arm: Implement tcg_out_mov for vector types, Richard Henderson, 2021/02/07
- Re: [PATCH v2 04/15] tcg/arm: Implement tcg_out_mov for vector types,
Peter Maydell <=
[PATCH v2 07/15] tcg/arm: Implement andc, orc, abs, neg, not vector operations, Richard Henderson, 2021/02/07
[PATCH v2 05/15] tcg/arm: Implement tcg_out_dup*_vec, Richard Henderson, 2021/02/07
[PATCH v2 06/15] tcg/arm: Implement minimal vector operations, Richard Henderson, 2021/02/07
[PATCH v2 08/15] tcg/arm: Implement TCG_TARGET_HAS_shi_vec, Richard Henderson, 2021/02/07
[PATCH v2 13/15] tcg/arm: Implement TCG_TARGET_HAS_shv_vec, Richard Henderson, 2021/02/07