Re: [PATCH v2 06/15] tcg/arm: Implement minimal vector operations

[Peter Maydell]

On Mon, 8 Feb 2021 at 03:53, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Implementing dup2, add, sub, and, or, xor as the minimal set.
> This allows us to actually enable neon in the header file.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tcg/arm/tcg-target-con-set.h |   3 +
>  tcg/arm/tcg-target-con-str.h |   2 +
>  tcg/arm/tcg-target.h         |   6 +-
>  tcg/arm/tcg-target.c.inc     | 203 +++++++++++++++++++++++++++++++++--
>  4 files changed, 206 insertions(+), 8 deletions(-)
> +    case INDEX_op_or_vec:
> +        if (const_args[2]) {
> +            is_shimm1632(a2, &cmode, &imm8);
> +            if (a0 == a1) {
> +                tcg_out_vmovi(s, a0, q, 0, cmode | 1, imm8); /* VORI */

Two 'R's in ORR.

> +                return;
> +            }

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM