[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grab
From: |
Gustavo Noronha Silva |
Subject: |
Re: [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed |
Date: |
Fri, 30 Apr 2021 07:02:46 -0300 |
User-agent: |
Cyrus-JMAP/3.5.0-alpha0-403-gbc3c488b23-fm-20210419.005-gbc3c488b |
Hey Markus,
On Fri, Apr 30, 2021, at 4:20 AM, Markus Armbruster wrote:
> Please indent like this
>
> # @full-grab: Capture all key presses, including system combos. This
> # requires accessibility permissions, since it performs
> # a global grab on key events. (default: off)
> # See
> https://support.apple.com/en-in/guide/mac-help/mh32356/mac
Will do, but just to be sure, the surrounding comments have the second to last
lines lined up to the C in Capture there, I assume that is what you mean?
> I hope the link is permanent.
So do I. I have found Apple to be fairly consistent in providing at least
proper redirection to newer versions of the documentation while learning about
Cocoa and the Mac itself (first timer, just interested in the M1 to be quite
honest), so I'm fairly confident it will survive.
Thanks for the review! I'll send a v2 later today.
Cheers,
Gustavo
Re: [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed, 'Gerd Hoffmann ', 2021/04/30
[PATCH 2/2] ui/cocoa: add option to swap Option and Command, enable by default, gustavo, 2021/04/29