[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grab
From: |
Gustavo Noronha Silva |
Subject: |
Re: [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed |
Date: |
Fri, 30 Apr 2021 09:02:23 -0300 |
User-agent: |
Cyrus-JMAP/3.5.0-alpha0-403-gbc3c488b23-fm-20210419.005-gbc3c488b |
Hey,
On Fri, Apr 30, 2021, at 7:58 AM, Markus Armbruster wrote:
> > I did not add a Since: here because I wasn't sure how that is handled.
> > Should I add something or is that taken care of at the time of release
> > somehow?
>
> You should add (since 6.1) at the end, like this
>
> # @full-grab: Capture all key presses, including system combos. This
> # requires accessibility permissions, since it performs
> # a global grab on key events. (default: off)
> # See https://support.apple.com/en-in/guide/mac-help/mh32356/mac
> # (Since 6.1)
>
> Same for @swap-option-command in the next patch.
>
> Glad you asked, I'm quite prone to not noticing missing these in
> review...
One last question, please bear with me =). Looking at the other options I see
that some have a single Since tag for the whole thing, I assume because they
were all added in one go. For instance, @DisplayGLMode has a single Since: 3.0
at the bottom and not one for each of the options. Should I do that as well
considering I'm adding @DisplayCocoa, or is the per-option Since still
preferred?
Thanks again,
Gustavo
Re: [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed, 'Gerd Hoffmann ', 2021/04/30
[PATCH 2/2] ui/cocoa: add option to swap Option and Command, enable by default, gustavo, 2021/04/29