Re: [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

[Markus Armbruster]

"Gustavo Noronha Silva" <gustavo@noronha.eti.br> writes:

> Oh by the way,
>
> On Fri, Apr 30, 2021, at 7:02 AM, Gustavo Noronha Silva wrote:
>> >    # @full-grab: Capture all key presses, including system combos. This
>> >    #             requires accessibility permissions, since it performs
>> >    #             a global grab on key events. (default: off)
>> >    #             See 
>> > https://support.apple.com/en-in/guide/mac-help/mh32356/mac
>
> I did not add a Since: here because I wasn't sure how that is handled. Should 
> I add something or is that taken care of at the time of release somehow?

You should add (since 6.1) at the end, like this

# @full-grab: Capture all key presses, including system combos. This
#             requires accessibility permissions, since it performs
#             a global grab on key events. (default: off)
#             See https://support.apple.com/en-in/guide/mac-help/mh32356/mac
#             (Since 6.1)

Same for @swap-option-command in the next patch.

Glad you asked, I'm quite prone to not noticing missing these in
review...