qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 34/41] target/ppc: Implement ppc_cpu_record_sigsegv


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 34/41] target/ppc: Implement ppc_cpu_record_sigsegv
Date: Sun, 19 Sep 2021 20:37:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

On 9/18/21 20:45, Richard Henderson wrote:
> Record DAR, DSISR, and exception_index.  That last means
> that we must exit to cpu_loop ourselves, instead of letting
> exception_index being overwritten.

Maybe complete:

"This is exactly what the user-mode ppc_cpu_tlb_fill() does,
so simply rename it as ppc_cpu_record_sigsegv()."

Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/ppc/cpu.h              |  3 ---
>  target/ppc/internal.h         |  9 +++++++++
>  target/ppc/cpu_init.c         |  6 ++++--
>  target/ppc/user_only_helper.c | 15 +++++++++++----
>  4 files changed, 24 insertions(+), 9 deletions(-)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]