|
From: | Richard Henderson |
Subject: | Re: [PATCH v5 08/31] accel/tcg: Implement AccelOpsClass::has_work() as stub |
Date: | Mon, 20 Sep 2021 15:01:49 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
On 9/20/21 2:44 PM, Philippe Mathieu-Daudé wrote:
+static bool tcg_cpu_has_work(CPUState *cpu) +{ + CPUClass *cc = CPU_GET_CLASS(cpu); + + g_assert(cc->tcg_ops->has_work); + return cc->tcg_ops->has_work(cpu); +}
Now, you're expecting cc->has_work to disappear as cc->tcg_ops->has_work appears. If we're expecting cc->has_work to not affect other accelerators, then I think you should first move cc->has_work to this function, *before* you add the tcg_ops hook.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |