Re: [PATCH v5 08/31] accel/tcg: Implement AccelOpsClass::has_work() as stub

[Philippe Mathieu-Daudé]

On 9/21/21 00:01, Richard Henderson wrote:
> On 9/20/21 2:44 PM, Philippe Mathieu-Daudé wrote:
> > +static bool tcg_cpu_has_work(CPUState *cpu)
> > +{
> > +    CPUClass *cc = CPU_GET_CLASS(cpu);
> > +
> > +    g_assert(cc->tcg_ops->has_work);
> > +    return cc->tcg_ops->has_work(cpu);
> > +}
>
> Now, you're expecting cc->has_work to disappear as cc->tcg_ops->has_work 
> appears.  If we're expecting cc->has_work to not affect other 
> accelerators, then I think you should first move cc->has_work to this 
> function, *before* you add the tcg_ops hook.

Indeed, thanks.