|
From: | WANG Xuerui |
Subject: | Re: [PATCH v2 12/30] tcg/loongarch64: Implement not/and/or/xor/nor/andc/orc/eqv ops |
Date: | Thu, 23 Sep 2021 01:23:28 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0a1 |
Hi Richard, On 9/22/21 12:35, Richard Henderson wrote:
On 9/21/21 1:18 PM, WANG Xuerui wrote:+ case INDEX_op_eqv_i32: + case INDEX_op_eqv_i64: + if (c2) { + /* guaranteed to fit due to constraint */ + tcg_out_opc_xori(s, a0, a1, ~a2); + } else { + tcg_out_opc_nor(s, a0, a2, TCG_REG_ZERO); + tcg_out_opc_xor(s, a0, a1, a0); + } + break;You don't actually have eqv (xnor), so don't pretend that you do. The middle-end will expand this as xor + not on its own.
Sure; I'll remove support for eqv in v3.
Otherwise, Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
[Prev in Thread] | Current Thread | [Next in Thread] |