|
From: | Richard Henderson |
Subject: | Re: [PATCH v2 09/30] tcg/loongarch64: Implement tcg_out_mov and tcg_out_movi |
Date: | Wed, 22 Sep 2021 08:17:24 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
On 9/22/21 8:16 AM, WANG Xuerui wrote:
Hi Richard, On 9/22/21 12:25, Richard Henderson wrote:On 9/21/21 1:18 PM, WANG Xuerui wrote:+ /* Test for PC-relative values that can be loaded faster. */ + intptr_t pc_offset = val - (uintptr_t)s->code_ptr;This isn't quite right for split r^x code buffer. You should have seen this with --enable-debug-tcg... You need pc_offset = tcg_pcrel_diff(s, (void *)val).Indeed; I just realized TCG debugging isn't fully enabled with --enable-debug only.
Um... it should be.
[Prev in Thread] | Current Thread | [Next in Thread] |