Re: [PATCH v5 19/30] tcg/loongarch64: Implement br/brcond ops

[Philippe Mathieu-Daudé]

On 9/24/21 19:25, WANG Xuerui wrote:
> Signed-off-by: WANG Xuerui <git@xen0n.name>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/loongarch64/tcg-target-con-set.h |  1 +
>   tcg/loongarch64/tcg-target.c.inc     | 53 ++++++++++++++++++++++++++++
>   2 files changed, 54 insertions(+)

> diff --git a/tcg/loongarch64/tcg-target.c.inc b/tcg/loongarch64/tcg-target.c.inc
> index e3aac6c3de..d2339d823d 100644
> --- a/tcg/loongarch64/tcg-target.c.inc
> +++ b/tcg/loongarch64/tcg-target.c.inc
> @@ -406,6 +406,44 @@ static void tcg_out_clzctz(TCGContext *s, LoongArchInsn 
> opc,
>       tcg_out_opc_or(s, a0, TCG_REG_TMP0, a0);
>   }
>   
> +/*
> + * Branch helpers
> + */
> +
> +static const struct {
> +    LoongArchInsn op;
> +    bool swap;
> +} tcg_brcond_to_loongarch[] = {

Richard, TCGCond is 4-bit, shouldn't we explicit this array
size to 16, and even better define TCG_COND_COUNT = 16 in
"tcg/tcg-cond.h"?

> +    [TCG_COND_EQ] =  { OPC_BEQ,  false },
> +    [TCG_COND_NE] =  { OPC_BNE,  false },
> +    [TCG_COND_LT] =  { OPC_BGT,  true  },
> +    [TCG_COND_GE] =  { OPC_BLE,  true  },
> +    [TCG_COND_LE] =  { OPC_BLE,  false },
> +    [TCG_COND_GT] =  { OPC_BGT,  false },
> +    [TCG_COND_LTU] = { OPC_BGTU, true  },
> +    [TCG_COND_GEU] = { OPC_BLEU, true  },
> +    [TCG_COND_LEU] = { OPC_BLEU, false },
> +    [TCG_COND_GTU] = { OPC_BGTU, false }
> +};

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>