Re: [PATCH v5 19/30] tcg/loongarch64: Implement br/brcond ops

[Richard Henderson]

On 9/25/21 6:13 AM, Philippe Mathieu-Daudé wrote:
> > +static const struct {
> > +    LoongArchInsn op;
> > +    bool swap;
> > +} tcg_brcond_to_loongarch[] = {
>
> Richard, TCGCond is 4-bit, shouldn't we explicit this array
> size to 16, and even better define TCG_COND_COUNT = 16 in
> "tcg/tcg-cond.h"?

Perhaps.  Not in this patch though.  None of the other instances in tcg/host/ do that, so 
I'd want to fix them all at once.


r~