[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: ebpf/rss.bpf.skeleton.h generated by what?
From: |
Jason Wang |
Subject: |
Re: ebpf/rss.bpf.skeleton.h generated by what? |
Date: |
Mon, 9 May 2022 17:35:34 +0800 |
On Mon, May 9, 2022 at 4:42 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Mon, 9 May 2022 at 06:30, Markus Armbruster <armbru@redhat.com> wrote:
> > Always, always, *always* document your reasons for doing stuff right in
> > the commit message, unless they are blindingly obvious. I understand
> > reasons can be obvious enough to the author. Document them anyway if
> > there is any chance they are not obvious to others.
>
> It's also nice for code-generators to say who they are
> in this kind of "this file is autogenerated" comment.
> For instance our own decodetree script's comments read
> /* This file is autogenerated by scripts/decodetree.py. */
Unfortunately, this is not what bpftool did right now.
Have posted a patch (with Markus and you cced).
Thanks
>
> -- PMM
>
- ebpf/rss.bpf.skeleton.h generated by what?, Markus Armbruster, 2022/05/06
- Re: ebpf/rss.bpf.skeleton.h generated by what?, Jason Wang, 2022/05/07
- Re: ebpf/rss.bpf.skeleton.h generated by what?, Paolo Bonzini, 2022/05/07
- Re: ebpf/rss.bpf.skeleton.h generated by what?, Jason Wang, 2022/05/07
- Re: ebpf/rss.bpf.skeleton.h generated by what?, Paolo Bonzini, 2022/05/07
- Re: ebpf/rss.bpf.skeleton.h generated by what?, Jason Wang, 2022/05/07
- Re: ebpf/rss.bpf.skeleton.h generated by what?, Markus Armbruster, 2022/05/09
- Re: ebpf/rss.bpf.skeleton.h generated by what?, Jason Wang, 2022/05/09
- Re: ebpf/rss.bpf.skeleton.h generated by what?, Peter Maydell, 2022/05/09
- Re: ebpf/rss.bpf.skeleton.h generated by what?,
Jason Wang <=
- Re: ebpf/rss.bpf.skeleton.h generated by what?, Andrew Melnichenko, 2022/05/10
- Re: ebpf/rss.bpf.skeleton.h generated by what?, Jason Wang, 2022/05/11
- Re: ebpf/rss.bpf.skeleton.h generated by what?, Markus Armbruster, 2022/05/11