Re: [PULL 00/16] migration queue

[Dr. David Alan Gilbert]

* Daniel P. Berrangé (berrange@redhat.com) wrote:
> On Tue, May 10, 2022 at 10:58:30AM +0100, Dr. David Alan Gilbert wrote:
> > * Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote:
> > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > > 
> > > The following changes since commit 
> > > 178bacb66d98d9ee7a702b9f2a4dfcd88b72a9ab:
> > > 
> > >   Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into 
> > > staging (2022-05-09 11:07:04 -0700)
> > > 
> > > are available in the Git repository at:
> > > 
> > >   https://gitlab.com/dagrh/qemu.git tags/pull-migration-20220510a
> > > 
> > > for you to fetch changes up to 511f4a0506af1d380115a61f3362149953646871:
> > > 
> > >   multifd: Implement zero copy write in multifd migration 
> > > (multifd-zero-copy) (2022-05-10 09:15:06 +0100)
> > 
> > Nack
> > This is still failing the Alpine build test:
> > 
> > ninja: job failed: cc -m64 -mcx16 -Ilibio.fa.p -I. -I.. -Iqapi -Itrace -Iui 
> > -Iui/shader -I/usr/include/p11-kit-1 -I/usr/include/glib-2.0 
> > -I/usr/lib/glib-2.0/include -fdiagnostics-color=auto -Wall -Winvalid-pch 
> > -Werror -std=gnu11 -O2 -g -isystem /builds/dagrh/qemu/linux-headers 
> > -isystem linux-headers -iquote . -iquote /builds/dagrh/qemu -iquote 
> > /builds/dagrh/qemu/include -iquote /builds/dagrh/qemu/disas/libvixl -iquote 
> > /builds/dagrh/qemu/tcg/i386 -pthread -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 
> > -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
> > -Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings 
> > -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv 
> > -Wold-style-declaration -Wold-style-definition -Wtype-limits 
> > -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers 
> > -Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined 
> > -Wimplicit-fallthrough=2 -Wno-missing-include-dirs 
> > -Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -fPIE -MD -MQ 
> > libio.fa.p/io_channel-socket.c.o -MF libio.fa.p/io_channel-socket.c.o.d -o 
> > libio.fa.p/io_channel-socket.c.o -c ../io/channel-socket.c
> > In file included from /usr/include/linux/errqueue.h:6,
> >                  from ../io/channel-socket.c:29:
> > /usr/include/linux/time_types.h:7:8: error: redefinition of 'struct 
> > __kernel_timespec'
> >     7 | struct __kernel_timespec {
> >       |        ^~~~~~~~~~~~~~~~~
> > In file included from /usr/include/liburing.h:19,
> >                  from /builds/dagrh/qemu/include/block/aio.h:18,
> >                  from /builds/dagrh/qemu/include/io/channel.h:26,
> >                  from /builds/dagrh/qemu/include/io/channel-socket.h:24,
> >                  from ../io/channel-socket.c:24:
> > /usr/include/liburing/compat.h:9:8: note: originally defined here
> >     9 | struct __kernel_timespec {
> >       |        ^~~~~~~~~~~~~~~~~
> > ninja: subcommand failed
> > make: *** [Makefile:163: run-ninja] Error 1
> 
> Yuk. That very much looks like a bug in liburing itself to me.
> 
> 
> We've exposed the latent bug by including linux/errqueue.h  

Yes, I think there was a thread after the 1st pull where Leo identified
the patch that fixed it; but it's not in that image.

Dave

> With regards,
> Daniel
> -- 
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK