[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/16] migration queue
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PULL 00/16] migration queue |
Date: |
Wed, 11 May 2022 09:55:14 +0100 |
User-agent: |
Mutt/2.2.1 (2022-02-19) |
* Leonardo Bras Soares Passos (leobras@redhat.com) wrote:
> From a previous thread:
>
> On Thu, Apr 28, 2022 at 1:20 PM Dr. David Alan Gilbert
> <dgilbert@redhat.com> wrote:
> >
> > Leo:
> > Unfortunately this is failing a couple of CI tests; the MSG_ZEROCOPY
> > one I guess is the simpler one; I think Stefanha managed to find the
> > liburing fix for the __kernel_timespec case, but that looks like a bit
> > more fun!
> >
> > Dave
>
> I thought Stefanha had fixed this bug, and we were just waiting for a
> new alpine rootfs/image with that fixed.
> Is that correct?
>
> On Tue, May 10, 2022 at 7:43 AM Dr. David Alan Gilbert
> <dgilbert@redhat.com> wrote:
> >
> > * Daniel P. Berrangé (berrange@redhat.com) wrote:
> > > On Tue, May 10, 2022 at 10:58:30AM +0100, Dr. David Alan Gilbert wrote:
> [...]
> > >
> > > Yuk. That very much looks like a bug in liburing itself to me.
> > >
> > >
> > > We've exposed the latent bug by including linux/errqueue.h
> >
> > Yes, I think there was a thread after the 1st pull where Leo identified
> > the patch that fixed it; but it's not in that image.
>
> I only fixed the MSG_ZEROCOPY missing define bug, as I got that
> Stefanha had already fixed the issue in liburing/alpine.
>
> questions:
> - Has Stefanha really fixed that, and we are just waiting for a new
> image, or have I got that wrong?
> - How should I proceed with that?
>
> - If we proceed with fixing this up in alpine, will that require this
> patchset to be on pause until it's fixed there?
It needs to pass in CI; so yes.
> - If so, is there any suggestion on how to fix that in qemu code?
> (this header is needed because of SO_EE_* defines)
I've not actually looked at the detail of the failure; but yes I think
we need a qemu workaround here.
If there's no simple fix, then adding a test to meson.build to
conditionally disable liburing might be best; like the test code for
libcap_ng I guess (search in meson.build for libcap_ng.found at around
line 540.
Dave
> Thank you all!
>
> Best regards,
> Leo
>
> >
> > Dave
> >
> > > With regards,
> > > Daniel
> > > --
> > > |: https://berrange.com -o-
> > > https://www.flickr.com/photos/dberrange :|
> > > |: https://libvirt.org -o-
> > > https://fstop138.berrange.com :|
> > > |: https://entangle-photo.org -o-
> > > https://www.instagram.com/dberrange :|
> > >
> > --
> > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> >
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- [PULL 12/16] migration: Add zero-copy-send parameter for QMP/HMP for Linux, (continued)
- [PULL 12/16] migration: Add zero-copy-send parameter for QMP/HMP for Linux, Dr. David Alan Gilbert (git), 2022/05/10
- [PULL 06/16] tests: convert multifd migration tests to use common helper, Dr. David Alan Gilbert (git), 2022/05/10
- [PULL 14/16] multifd: multifd_send_sync_main now returns negative on error, Dr. David Alan Gilbert (git), 2022/05/10
- [PULL 13/16] migration: Add migrate_use_tls() helper, Dr. David Alan Gilbert (git), 2022/05/10
- [PULL 15/16] multifd: Send header packet without flags if zero-copy-send is enabled, Dr. David Alan Gilbert (git), 2022/05/10
- [PULL 16/16] multifd: Implement zero copy write in multifd migration (multifd-zero-copy), Dr. David Alan Gilbert (git), 2022/05/10
- Re: [PULL 00/16] migration queue, Dr. David Alan Gilbert, 2022/05/10
- Re: [PULL 00/16] migration queue, Daniel P . Berrangé, 2022/05/10
- Re: [PULL 00/16] migration queue, Dr. David Alan Gilbert, 2022/05/10
- Re: [PULL 00/16] migration queue, Leonardo Bras Soares Passos, 2022/05/10
- Re: [PULL 00/16] migration queue,
Dr. David Alan Gilbert <=
- Re: [PULL 00/16] migration queue, Leonardo Bras Soares Passos, 2022/05/13
- Re: [PULL 00/16] migration queue, Dr. David Alan Gilbert, 2022/05/16
- Re: [PULL 00/16] migration queue, Stefan Hajnoczi, 2022/05/16
- Re: [PULL 00/16] migration queue, Daniel P . Berrangé, 2022/05/16
- Re: [PULL 00/16] migration queue, Daniel P . Berrangé, 2022/05/16
- Re: [PULL 00/16] migration queue, Stefan Hajnoczi, 2022/05/16