Re: [PATCH] hw/ppc: ppc440_uc: avoid multiply overflow in dcr_write_dma()

[Peter Maydell]

On Sat, 6 Aug 2022 at 12:17, Daniel Henrique Barboza
<danielhb413@gmail.com> wrote:
>
> Balaton,
>
> I had a change of heart. The code is too clear that it won't overflow.
> It felt overkill changing var types just for that.
>
> Peter already marked it as Ignored - False Positive in Coverity as well.
> So this would be a code change to "look better". It didn't look particularly
> better after the changes I was about to send, so let's forget about it.

Yeah, I marked it false positive because the limit on the two
inputs to the multiply is very clear in the code. (Usually I
put a note about why when I mark something an FP, but you have
to expand the 'Triage' section in the right hand panel of the
Coverity Scan web UI to show that text.)

-- PMM