Re: [PATCH] hw/ppc: ppc440_uc: avoid multiply overflow in dcr_write_dma()

[BALATON Zoltan]

On Sat, 6 Aug 2022, Peter Maydell wrote:
> On Sat, 6 Aug 2022 at 12:24, BALATON Zoltan <balaton@eik.bme.hu> wrote:
> > I may look at it later when Peter's second patch changing
> > this code lands if there are any cleanups possible
>
> You mean the 2nd patch I sent in that RFC series? I'm not

Yes I mean that patch.

> currently totally sure what I want to do with that. Looking
> at the code and at the docs that describe how the device
> works, there's definitely quite a bit of missing
> functionality. So I'm sort of undecided between "do a fair

As the original commit message says I only aimed for the functionality 
AmigaOS seems to use and did not try to implement everything. What we have 
now seems to be enough for AmigaOS but I don't know if there are any other 
functionality it may want to use in rare cases that I don't know about or 
there are other guests that would do so.

> bit of overhaul to the device to fix up the more obviously
> missing pieces (but without much ability to test the changes)"
> and "just leave the code as it is in git at the moment, since
> it's sufficient for the only guest we know touches it to be
> able to boot". What would you prefer?

I won't stop you if you want to improve this device but I also don't know 
how to test it apart from verifying AmigaOS still boots and works. It did 
with your second patch (I've sent a Tested-by) and I'll test any further 
patches. So just fixing the obviously wrong parts without adding any new 
functionality is probably enough if you don't want to spend too much time 
with it. I'll try to gather some traces on how AmigaOS uses it to help you 
to judge what's needed.

Thank you,
BALATON Zoltan