Re: [PATCH] hw/ppc: ppc440_uc: avoid multiply overflow in dcr_write_dma()

[Peter Maydell]

On Sat, 6 Aug 2022 at 12:24, BALATON Zoltan <balaton@eik.bme.hu> wrote:
> I may look at it later when Peter's second patch changing
> this code lands if there are any cleanups possible

You mean the 2nd patch I sent in that RFC series? I'm not
currently totally sure what I want to do with that. Looking
at the code and at the docs that describe how the device
works, there's definitely quite a bit of missing
functionality. So I'm sort of undecided between "do a fair
bit of overhaul to the device to fix up the more obviously
missing pieces (but without much ability to test the changes)"
and "just leave the code as it is in git at the moment, since
it's sufficient for the only guest we know touches it to be
able to boot". What would you prefer?

thanks
-- PMM