[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/7] configure: Remove unused python_version variable
From: |
Peter Maydell |
Subject: |
[PATCH 1/7] configure: Remove unused python_version variable |
Date: |
Thu, 25 Aug 2022 16:06:57 +0100 |
Shellcheck correctly reports that we set python_version and never use
it. This is a leftover from commit f9332757898a7: we used to use
python_version purely to as part of the summary information printed
at the end of a configure run, and that commit changed to printing
the information from meson (which looks up the python version
itself). Remove the unused variable.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
configure | 3 ---
1 file changed, 3 deletions(-)
diff --git a/configure b/configure
index 72ab03f11aa..efe28050234 100755
--- a/configure
+++ b/configure
@@ -1112,9 +1112,6 @@ if ! $python -c 'import sys; sys.exit(sys.version_info <
(3,6))'; then
"Use --python=/path/to/python to specify a supported Python."
fi
-# Preserve python version since some functionality is dependent on it
-python_version=$($python -c 'import sys; print("%d.%d.%d" %
(sys.version_info[0], sys.version_info[1], sys.version_info[2]))' 2>/dev/null)
-
# Suppress writing compiled files
python="$python -B"
--
2.25.1
- [PATCH 0/7] configure: fix misc shellcheck warnings, Peter Maydell, 2022/08/25
- [PATCH 1/7] configure: Remove unused python_version variable,
Peter Maydell <=
- [PATCH 2/7] configure: Remove unused meson_args variable, Peter Maydell, 2022/08/25
- [PATCH 4/7] configure: Add './' on front of glob of */config-devices.mak.d, Peter Maydell, 2022/08/25
- [PATCH 3/7] configure: Add missing quoting for some easy cases, Peter Maydell, 2022/08/25
- [PATCH 6/7] configure: Check mkdir result directly, not via $?, Peter Maydell, 2022/08/25
- [PATCH 7/7] configure: Avoid use of 'local' as it is non-POSIX, Peter Maydell, 2022/08/25
- [PATCH 5/7] configure: Remove use of backtick `...` syntax, Peter Maydell, 2022/08/25
- Re: [PATCH 0/7] configure: fix misc shellcheck warnings, Marc-André Lureau, 2022/08/26