qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/7] configure: Add './' on front of glob of */config-devices


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 4/7] configure: Add './' on front of glob of */config-devices.mak.d
Date: Tue, 30 Aug 2022 14:12:50 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 25/8/22 17:07, Peter Maydell wrote:
Shellcheck warns that in
  rm -f */config-devices.mak.d
the glob might expand to something with a '-' in it, which would
then be misinterpreted as an option to rm.

Interesting, TIL.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Fix this by adding './'.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
  configure | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 894642554c3..d5b6546ae81 100755
--- a/configure
+++ b/configure
@@ -1093,7 +1093,7 @@ exit 0
  fi
# Remove old dependency files to make sure that they get properly regenerated
-rm -f */config-devices.mak.d
+rm -f ./*/config-devices.mak.d
if test -z "$python"
  then




reply via email to

[Prev in Thread] Current Thread [Next in Thread]