[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 6/7] configure: Check mkdir result directly, not via $?
From: |
Peter Maydell |
Subject: |
[PATCH 6/7] configure: Check mkdir result directly, not via $? |
Date: |
Thu, 25 Aug 2022 16:07:02 +0100 |
Shellcheck warns that we have one place where we run a command and
then check if it failed using $?; this is better written to simply
check the command in the 'if' statement directly.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
configure | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/configure b/configure
index 5c1992d5bce..f8d7270a60e 100755
--- a/configure
+++ b/configure
@@ -67,8 +67,7 @@ fi
# it when configure exits.)
TMPDIR1="config-temp"
rm -rf "${TMPDIR1}"
-mkdir -p "${TMPDIR1}"
-if [ $? -ne 0 ]; then
+if ! mkdir -p "${TMPDIR1}"; then
echo "ERROR: failed to create temporary directory"
exit 1
fi
--
2.25.1
- [PATCH 0/7] configure: fix misc shellcheck warnings, Peter Maydell, 2022/08/25
- [PATCH 1/7] configure: Remove unused python_version variable, Peter Maydell, 2022/08/25
- [PATCH 2/7] configure: Remove unused meson_args variable, Peter Maydell, 2022/08/25
- [PATCH 4/7] configure: Add './' on front of glob of */config-devices.mak.d, Peter Maydell, 2022/08/25
- [PATCH 3/7] configure: Add missing quoting for some easy cases, Peter Maydell, 2022/08/25
- [PATCH 6/7] configure: Check mkdir result directly, not via $?,
Peter Maydell <=
- [PATCH 7/7] configure: Avoid use of 'local' as it is non-POSIX, Peter Maydell, 2022/08/25
- [PATCH 5/7] configure: Remove use of backtick `...` syntax, Peter Maydell, 2022/08/25
- Re: [PATCH 0/7] configure: fix misc shellcheck warnings, Marc-André Lureau, 2022/08/26
- Re: [PATCH 0/7] configure: fix misc shellcheck warnings, Philippe Mathieu-Daudé, 2022/08/30