Re: [PATCH 08/23] i386: isolate MMX code more

[Richard Henderson]

On 8/26/22 16:11, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   target/i386/tcg/translate.c | 52 +++++++++++++++++++++++--------------
>   1 file changed, 33 insertions(+), 19 deletions(-)
>
> diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
> index 849c40b685..f174b1d986 100644
> --- a/target/i386/tcg/translate.c
> +++ b/target/i386/tcg/translate.c
> @@ -3888,6 +3888,12 @@ static void gen_sse(CPUX86State *env, DisasContext *s, 
> int b,
>                           gen_ldo_env_A0(s, op2_offset);
>                       }
>                   }
> +                tcg_gen_addi_ptr(s->ptr0, cpu_env, op1_offset);
> +                tcg_gen_addi_ptr(s->ptr1, cpu_env, op2_offset);
> +                if (!op6->op[b1]) {
> +                    goto illegal_op;
> +                }

Illegal check should be above code gen.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~