Re: [PATCH 23/23] i386: AVX+AES helpers prep

[Richard Henderson]

On 8/26/22 16:12, Paolo Bonzini wrote:
> From: Paul Brook <paul@nowt.org>
>
> Make the AES vector helpers AVX ready
>
> No functional changes to existing helpers
>
> Signed-off-by: Paul Brook <paul@nowt.org>
> Message-Id: <20220424220204.2493824-22-paul@nowt.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   target/i386/ops_sse.h | 49 +++++++++++++++++++++++--------------------
>   1 file changed, 26 insertions(+), 23 deletions(-)
>
> diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h
> index 2b35b6e533..a42d7b26ba 100644
> --- a/target/i386/ops_sse.h
> +++ b/target/i386/ops_sse.h
> @@ -2289,64 +2289,66 @@ void glue(helper_pclmulqdq, SUFFIX)(CPUX86State *env, 
> Reg *d, Reg *s,
>   void glue(helper_aesdec, SUFFIX)(CPUX86State *env, Reg *d, Reg *s)
>   {
>       int i;
> -    Reg st = *d;
> +    Reg st = *d; // v

No c++ comments.  Otherwise,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~