qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 15/23] i386: Destructive vector helpers for AVX


From: Paolo Bonzini
Subject: Re: [PATCH 15/23] i386: Destructive vector helpers for AVX
Date: Sat, 27 Aug 2022 08:22:47 +0200



Il sab 27 ago 2022, 01:46 Richard Henderson <richard.henderson@linaro.org> ha scritto:
> +#define PACK_WIDTH (4 << SHIFT)

Incorrect for AVX, it was correct with the ifdef in v1.
Perhaps just (SHIFT ? 8 : 4)?

That's intentional, the AVX patches change it to an #ifndef that AVX overrides. For now the purpose of the series is to keep things simple and loop-ified, with AVX remaining in the background. But I can use the ternary operator if you prefer, that's a good suggestion too.

Paolo


I think this should be parameterized on the larger of
the two types in the insn.  Because right now you get
some weird arithmetic in e.g. punpck*dq.


r~
,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]