qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/23] i386: do not cast gen_helper_* function pointers


From: Richard Henderson
Subject: Re: [PATCH 10/23] i386: do not cast gen_helper_* function pointers
Date: Fri, 26 Aug 2022 16:32:13 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 8/26/22 16:11, Paolo Bonzini wrote:
Use a union to store the various possible kinds of function pointers, and
access the correct one based on the flags.

SSEOpHelper_table6 and SSEOpHelper_table7 right now only have one case,
but this would change with AVX's 3- and 4-argument operations.  Use
unions there too, to keep the code more similar for the three tables.

Extracted from a patch by Paul Brook<paul@nowt.org>.

Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
---
  target/i386/tcg/translate.c | 75 ++++++++++++++++++-------------------
  1 file changed, 37 insertions(+), 38 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]