[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 6/8] hw/net: rtl8139: Remove the logic of padding short frames
From: |
bmeng . cn |
Subject: |
[PATCH v6 6/8] hw/net: rtl8139: Remove the logic of padding short frames in the receive path |
Date: |
Wed, 1 Mar 2023 17:02:01 +0800 |
From: Bin Meng <bmeng.cn@gmail.com>
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
hw/net/rtl8139.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
index 5a5aaf868d..a52b961bda 100644
--- a/hw/net/rtl8139.c
+++ b/hw/net/rtl8139.c
@@ -826,7 +826,6 @@ static ssize_t rtl8139_do_receive(NetClientState *nc, const
uint8_t *buf, size_t
uint32_t packet_header = 0;
- uint8_t buf1[MIN_BUF_SIZE + VLAN_HLEN];
static const uint8_t broadcast_macaddr[6] =
{ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
@@ -938,17 +937,6 @@ static ssize_t rtl8139_do_receive(NetClientState *nc,
const uint8_t *buf, size_t
}
}
- /* if too small buffer, then expand it
- * Include some tailroom in case a vlan tag is later removed. */
- if (size < MIN_BUF_SIZE + VLAN_HLEN) {
- memcpy(buf1, buf, size);
- memset(buf1 + size, 0, MIN_BUF_SIZE + VLAN_HLEN - size);
- buf = buf1;
- if (size < MIN_BUF_SIZE) {
- size = MIN_BUF_SIZE;
- }
- }
-
if (rtl8139_cp_receiver_enabled(s))
{
if (!rtl8139_cp_rx_valid(s)) {
--
2.34.1
- [PATCH v6 0/8] net: Pad short frames for network backends, bmeng . cn, 2023/03/01
- [PATCH v6 1/8] hw/net: e1000: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 2/8] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 6/8] hw/net: rtl8139: Remove the logic of padding short frames in the receive path,
bmeng . cn <=
- [PATCH v6 7/8] hw/net: sungem: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 3/8] hw/net: i82596: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 4/8] hw/net: ne2000: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 5/8] hw/net: pcnet: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 8/8] hw/net: sunhme: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- Re: [PATCH v6 0/8] net: Pad short frames for network backends, Cédric Le Goater, 2023/03/01