[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 4/8] hw/net: ne2000: Remove the logic of padding short frames
From: |
bmeng . cn |
Subject: |
[PATCH v6 4/8] hw/net: ne2000: Remove the logic of padding short frames in the receive path |
Date: |
Wed, 1 Mar 2023 17:01:59 +0800 |
From: Bin Meng <bmeng.cn@gmail.com>
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
hw/net/ne2000.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c
index 3f31d04efb..d79c884d50 100644
--- a/hw/net/ne2000.c
+++ b/hw/net/ne2000.c
@@ -167,15 +167,12 @@ static int ne2000_buffer_full(NE2000State *s)
return 0;
}
-#define MIN_BUF_SIZE 60
-
ssize_t ne2000_receive(NetClientState *nc, const uint8_t *buf, size_t size_)
{
NE2000State *s = qemu_get_nic_opaque(nc);
size_t size = size_;
uint8_t *p;
unsigned int total_len, next, avail, len, index, mcast_idx;
- uint8_t buf1[60];
static const uint8_t broadcast_macaddr[6] =
{ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
@@ -213,15 +210,6 @@ ssize_t ne2000_receive(NetClientState *nc, const uint8_t
*buf, size_t size_)
}
}
-
- /* if too small buffer, then expand it */
- if (size < MIN_BUF_SIZE) {
- memcpy(buf1, buf, size);
- memset(buf1 + size, 0, MIN_BUF_SIZE - size);
- buf = buf1;
- size = MIN_BUF_SIZE;
- }
-
index = s->curpag << 8;
if (index >= NE2000_PMEM_END) {
index = s->start;
--
2.34.1
- [PATCH v6 0/8] net: Pad short frames for network backends, bmeng . cn, 2023/03/01
- [PATCH v6 1/8] hw/net: e1000: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 2/8] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 6/8] hw/net: rtl8139: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 7/8] hw/net: sungem: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 3/8] hw/net: i82596: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 4/8] hw/net: ne2000: Remove the logic of padding short frames in the receive path,
bmeng . cn <=
- [PATCH v6 5/8] hw/net: pcnet: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 8/8] hw/net: sunhme: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- Re: [PATCH v6 0/8] net: Pad short frames for network backends, Cédric Le Goater, 2023/03/01