[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 7/8] hw/net: sungem: Remove the logic of padding short frames
From: |
bmeng . cn |
Subject: |
[PATCH v6 7/8] hw/net: sungem: Remove the logic of padding short frames in the receive path |
Date: |
Wed, 1 Mar 2023 17:02:02 +0800 |
From: Bin Meng <bmeng.cn@gmail.com>
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
hw/net/sungem.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/hw/net/sungem.c b/hw/net/sungem.c
index eb01520790..103376c133 100644
--- a/hw/net/sungem.c
+++ b/hw/net/sungem.c
@@ -550,7 +550,6 @@ static ssize_t sungem_receive(NetClientState *nc, const
uint8_t *buf,
PCIDevice *d = PCI_DEVICE(s);
uint32_t mac_crc, done, kick, max_fsize;
uint32_t fcs_size, ints, rxdma_cfg, rxmac_cfg, csum, coff;
- uint8_t smallbuf[60];
struct gem_rxd desc;
uint64_t dbase, baddr;
unsigned int rx_cond;
@@ -584,19 +583,6 @@ static ssize_t sungem_receive(NetClientState *nc, const
uint8_t *buf,
return size;
}
- /* We don't drop too small frames since we get them in qemu, we pad
- * them instead. We should probably use the min frame size register
- * but I don't want to use a variable size staging buffer and I
- * know both MacOS and Linux use the default 64 anyway. We use 60
- * here to account for the non-existent FCS.
- */
- if (size < 60) {
- memcpy(smallbuf, buf, size);
- memset(&smallbuf[size], 0, 60 - size);
- buf = smallbuf;
- size = 60;
- }
-
/* Get MAC crc */
mac_crc = net_crc32_le(buf, ETH_ALEN);
--
2.34.1
- [PATCH v6 0/8] net: Pad short frames for network backends, bmeng . cn, 2023/03/01
- [PATCH v6 1/8] hw/net: e1000: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 2/8] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 6/8] hw/net: rtl8139: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 7/8] hw/net: sungem: Remove the logic of padding short frames in the receive path,
bmeng . cn <=
- [PATCH v6 3/8] hw/net: i82596: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 4/8] hw/net: ne2000: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 5/8] hw/net: pcnet: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- [PATCH v6 8/8] hw/net: sunhme: Remove the logic of padding short frames in the receive path, bmeng . cn, 2023/03/01
- Re: [PATCH v6 0/8] net: Pad short frames for network backends, Cédric Le Goater, 2023/03/01