[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 69/91] target/arm: Handle FPROUNDING_ODD in arm_rmode_to_sf
From: |
Richard Henderson |
Subject: |
[PULL v2 69/91] target/arm: Handle FPROUNDING_ODD in arm_rmode_to_sf |
Date: |
Thu, 9 Mar 2023 12:05:28 -0800 |
While this enumerator has been present since the first commit,
it isn't ever used. The first actual use of round-to-odd came
with SVE, which currently uses float_round_to_odd instead of
the arm-specific enumerator.
Amusingly, the comment about unhandled TIEAWAY has been
out of date since the initial commit of translate-a64.c.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/vfp_helper.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/target/arm/vfp_helper.c b/target/arm/vfp_helper.c
index 24e3d820a5..90cc324f71 100644
--- a/target/arm/vfp_helper.c
+++ b/target/arm/vfp_helper.c
@@ -1111,10 +1111,8 @@ int arm_rmode_to_sf(int rmode)
rmode = float_round_ties_away;
break;
case FPROUNDING_ODD:
- /* FIXME: add support for TIEAWAY and ODD */
- qemu_log_mask(LOG_UNIMP, "arm: unimplemented rounding mode: %d\n",
- rmode);
- /* fall through for now */
+ rmode = float_round_to_odd;
+ break;
case FPROUNDING_TIEEVEN:
default:
rmode = float_round_nearest_even;
--
2.34.1
- [PULL v2 60/91] target/sh4: Avoid tcg_const_i32, (continued)
- [PULL v2 60/91] target/sh4: Avoid tcg_const_i32, Richard Henderson, 2023/03/09
- [PULL v2 59/91] target/sh4: Avoid tcg_const_i32 for TAS.B, Richard Henderson, 2023/03/09
- [PULL v2 61/91] tcg/sparc: Avoid tcg_const_tl in gen_edge, Richard Henderson, 2023/03/09
- [PULL v2 62/91] target/tricore: Split t_n as constant from temp as variable, Richard Henderson, 2023/03/09
- [PULL v2 63/91] target/tricore: Rename t_off10 and use tcg_constant_i32, Richard Henderson, 2023/03/09
- [PULL v2 65/91] target/tricore: Drop some temp initialization, Richard Henderson, 2023/03/09
- [PULL v2 68/91] target/arm: Use rmode >= 0 for need_rmode, Richard Henderson, 2023/03/09
- [PULL v2 64/91] target/tricore: Use setcondi instead of explicit allocation, Richard Henderson, 2023/03/09
- [PULL v2 67/91] tcg: Replace tcg_const_i64 in tcg-op.c, Richard Henderson, 2023/03/09
- [PULL v2 66/91] target/tricore: Avoid tcg_const_i32, Richard Henderson, 2023/03/09
- [PULL v2 69/91] target/arm: Handle FPROUNDING_ODD in arm_rmode_to_sf,
Richard Henderson <=
- [PULL v2 70/91] target/arm: Improve arm_rmode_to_sf, Richard Henderson, 2023/03/09
- [PULL v2 74/91] target/arm: Avoid tcg_const_ptr in gen_sve_{ldr,str}, Richard Henderson, 2023/03/09
- [PULL v2 78/91] target/arm: Avoid tcg_const_ptr in handle_rev, Richard Henderson, 2023/03/09
- [PULL v2 71/91] target/arm: Consistently use ARMFPRounding during translation, Richard Henderson, 2023/03/09
- [PULL v2 72/91] target/arm: Create gen_set_rmode, gen_restore_rmode, Richard Henderson, 2023/03/09
- [PULL v2 79/91] target/m68k: Use tcg_constant_i32 in gen_ea_mode, Richard Henderson, 2023/03/09
- [PULL v2 77/91] target/arm: Avoid tcg_const_ptr in handle_vec_simd_sqshrn, Richard Henderson, 2023/03/09
- [PULL v2 75/91] target/arm: Avoid tcg_const_* in translate-mve.c, Richard Henderson, 2023/03/09
- [PULL v2 76/91] target/arm: Avoid tcg_const_ptr in disas_simd_zip_trn, Richard Henderson, 2023/03/09
- [PULL v2 73/91] target/arm: Improve trans_BFCI, Richard Henderson, 2023/03/09