[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 11/18] ui/sdl: get the GL context from the window
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v3 11/18] ui/sdl: get the GL context from the window |
|
Date: |
Mon, 13 Mar 2023 10:18:41 +0000 |
|
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Mon, Mar 13, 2023 at 02:12:00PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> There is no guarantee to have a current GL context here. The current
> code seems to rely on the renderer using a GL backend, and to set a
> current GL context. But this is not always the case, for example if the
> renderer backend is DirectX.
>
> This change is enough to fix using virgl with sdl2 on win32, on my setup.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/sdl2.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v3 07/18] ui: rename cursor_{get->ref}, return it, (continued)
- [PATCH v3 07/18] ui: rename cursor_{get->ref}, return it, marcandre . lureau, 2023/03/13
- [PATCH v3 08/18] ui: keep current cursor with QemuConsole, marcandre . lureau, 2023/03/13
- [PATCH v3 09/18] ui: set cursor upon listener registration, marcandre . lureau, 2023/03/13
- [PATCH v3 10/18] ui: set cursor position upon listener registration, marcandre . lureau, 2023/03/13
- [PATCH v3 13/18] ui/egl: print EGL error, helping debugging, marcandre . lureau, 2023/03/13
- [PATCH v3 14/18] ui/sdl: add QEMU_ENABLE_SDL_LOGGING setting/environment, marcandre . lureau, 2023/03/13
- [PATCH v3 16/18] ui: introduce egl_init(), marcandre . lureau, 2023/03/13
- [PATCH v3 11/18] ui/sdl: get the GL context from the window, marcandre . lureau, 2023/03/13
- Re: [PATCH v3 11/18] ui/sdl: get the GL context from the window,
Daniel P . Berrangé <=
- [PATCH v3 12/18] ui/shader: fix #version directive must occur on first line, marcandre . lureau, 2023/03/13
- [PATCH v3 15/18] ui/sdl: try to instantiate the matching opengl renderer, marcandre . lureau, 2023/03/13
- [PATCH v3 17/18] ui/dbus: do not require opengl & gbm, marcandre . lureau, 2023/03/13
- [PATCH v3 18/18] ui/dbus: restrict opengl to gbm-enabled config, marcandre . lureau, 2023/03/13