[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 16/18] ui: introduce egl_init()
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v3 16/18] ui: introduce egl_init() |
Date: |
Mon, 13 Mar 2023 10:22:02 +0000 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Mon, Mar 13, 2023 at 02:12:05PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Future patches will introduce EGL support on win32 (too late for 8.0
> though). Having a common place for EGL initialization and error handling
> will make it simpler.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> include/ui/egl-helpers.h | 2 ++
> ui/dbus.c | 7 +------
> ui/egl-headless.c | 16 ++++++++--------
> ui/egl-helpers.c | 24 ++++++++++++++++++++++++
> ui/spice-core.c | 7 +------
> 5 files changed, 36 insertions(+), 20 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v3 04/18] ui/dbus: set mouse is-absolute during console creation, (continued)
- [PATCH v3 04/18] ui/dbus: set mouse is-absolute during console creation, marcandre . lureau, 2023/03/13
- [PATCH v3 06/18] ui: rename cursor_{put->unref}, marcandre . lureau, 2023/03/13
- [PATCH v3 07/18] ui: rename cursor_{get->ref}, return it, marcandre . lureau, 2023/03/13
- [PATCH v3 08/18] ui: keep current cursor with QemuConsole, marcandre . lureau, 2023/03/13
- [PATCH v3 09/18] ui: set cursor upon listener registration, marcandre . lureau, 2023/03/13
- [PATCH v3 10/18] ui: set cursor position upon listener registration, marcandre . lureau, 2023/03/13
- [PATCH v3 13/18] ui/egl: print EGL error, helping debugging, marcandre . lureau, 2023/03/13
- [PATCH v3 14/18] ui/sdl: add QEMU_ENABLE_SDL_LOGGING setting/environment, marcandre . lureau, 2023/03/13
- [PATCH v3 16/18] ui: introduce egl_init(), marcandre . lureau, 2023/03/13
- Re: [PATCH v3 16/18] ui: introduce egl_init(),
Daniel P . Berrangé <=
- [PATCH v3 11/18] ui/sdl: get the GL context from the window, marcandre . lureau, 2023/03/13
- [PATCH v3 12/18] ui/shader: fix #version directive must occur on first line, marcandre . lureau, 2023/03/13
- [PATCH v3 15/18] ui/sdl: try to instantiate the matching opengl renderer, marcandre . lureau, 2023/03/13
- [PATCH v3 17/18] ui/dbus: do not require opengl & gbm, marcandre . lureau, 2023/03/13
- [PATCH v3 18/18] ui/dbus: restrict opengl to gbm-enabled config, marcandre . lureau, 2023/03/13