Re: [PATCH v7 0/3] Add emulation of AmigaOne XE board

[Daniel Henrique Barboza]

On 11/7/23 11:42, BALATON Zoltan wrote:
> On Tue, 7 Nov 2023, BALATON Zoltan wrote:
> > On Mon, 6 Nov 2023, BALATON Zoltan wrote:
> > > On Fri, 27 Oct 2023, BALATON Zoltan wrote:
> > > > Changes in v7:
> > > > - Increase default memory size to 512m to match pegasos2 and sam460ex
> > > > and it's a better default for AmigaOS
> > > >
> > > > Changes in v6:
> > > > - Dropped patch 1, now it's
> > > >
> > > > Based-on: <20231024224056.842607-1-mark.cave-ayland@ilande.co.uk>
> > > >
> > > > ([PATCH v2 0/3] ide: implement simple legacy/native mode switching for PCI IDE 
> > > > controllers)
> > > > - Added Tested-by from Rene
> > > >
> > > > Changes in v5:
> > > > - Fixed avocado test
> > > >
> > > > Changes in v4:
> > > > - Found typo in comment in patch 1 so ended up rewording it again
> > > > trying to make it more concise. Also take the idea of using
> > > > range_covers_byte from Mark's patch
> > > > - Added RFC patch for avocado test (untested, I don't have Avocado)
> > > >
> > > > Changes in v3:
> > > > - Update values, comment and commit message in patch 1 again
> > > >
> > > > Changes in v2:
> > > > - Update comment and commit message in patch 1 (Mark)
> > > > - Fix irq mapping in patch 2 (Volker)
> > > >
> > > > Regards,
> > > > BALATON Zoltan
> > > >
> > > > BALATON Zoltan (3):
> > > >  hw/pci-host: Add emulation of Mai Logic Articia S
> > > >  hw/ppc: Add emulation of AmigaOne XE board
> > > >  tests/avocado: Add test for amigaone board
> > >
> > > Nick,
> > >
> > > Will you please send a pull request with this now? It's independent of the IDE 
> > > fix which as a bugfix so can wait a little more but this series should be 
> > > merged before the freeze starts tomorrow. (As this adds a new machine and does 
> > > not touch anything else it can't break anything either.)
> >
> > Is there a PPC pull request in the making with this series in it? It would be 
> > really sad to miss the release not being able to merge such a simple series for 
> > weeks. As I said this is independent of any other fixes so I'd like to get this 
> > in now please.
>
> Nick seems to be away so please Cédric, Daniel, Phil or whoever can send a pull 
> request step in and please take care of this. This was posted a month ago with 
> this last version on the list for 1.5 week so I'd hate to miss the release and 
> wait until Easter next year to get this out to users because none of the 
> maintainers are available before and arounf the freeze.

Wait, do you think we would miss code freeze?

Code freeze in QEMU is a blast! People getting mad because stuff got left 
behind,
PRs getting remade over and over because gitlab is nagging about something, new
bugs introduced, sometimes master doesn't even build the following week. We 
might
miss any other boring date like release date or something, but code freeze? Nah,
we're right here man.

The reason why we didn't interfere is because it's rude to short-circuit the
maintainer on duty. Nick didn't send an email asking for help, so we were just
monitoring.

I'll consider Nick AWOL and take this PR. And don't worry, it's still sunny in
Brazil, we have plenty of time.


Thanks,

Daniel

> Regards,
> BALATON Zoltan
>
> > > > MAINTAINERS                             |   8 +
> > > > configs/devices/ppc-softmmu/default.mak |   1 +
> > > > hw/pci-host/Kconfig                     |   5 +
> > > > hw/pci-host/articia.c                   | 293 ++++++++++++++++++++++++
> > > > hw/pci-host/meson.build                 |   2 +
> > > > hw/ppc/Kconfig                          |   7 +
> > > > hw/ppc/amigaone.c                       | 164 +++++++++++++
> > > > hw/ppc/meson.build                      |   2 +
> > > > include/hw/pci-host/articia.h           |  17 ++
> > > > tests/avocado/ppc_amiga.py              |  38 +++
> > > > 10 files changed, 537 insertions(+)
> > > > create mode 100644 hw/pci-host/articia.c
> > > > create mode 100644 hw/ppc/amigaone.c
> > > > create mode 100644 include/hw/pci-host/articia.h
> > > > create mode 100644 tests/avocado/ppc_amiga.py