qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 0/3] Add emulation of AmigaOne XE board


From: BALATON Zoltan
Subject: Re: [PATCH v7 0/3] Add emulation of AmigaOne XE board
Date: Tue, 7 Nov 2023 19:18:44 +0100 (CET)

On Tue, 7 Nov 2023, Peter Maydell wrote:
On Tue, 7 Nov 2023 at 18:05, BALATON Zoltan <balaton@eik.bme.hu> wrote:
So if it's tests/qtest/test-hmp.c that seems to try to run a bunch of
command for each machine AFAIU. This machine needs a firmware image but
this test seems to run it with -S and never starts the machine so could
take any file with -bios for that, e.g. -bios vof.bin (thought about -bios
/dev/null but that does not work but any other file should probably be
OK). I don't know how to tell test-hmp to use that thogh or to skip this
machine.

At some point pegasos2 also needed a firmware but this wasn't a problem
back then. Either this test is new or we could just ignore this error?

The test has been around for a long time, and no, you can't ignore
'make check' failures, they will break the CI. It's one of
the tests we have that test properties that must be true for
all board types (or all devices, in the case of some other
tests). One of the properties is "it ought to start up cleanly
without extra arguments".

I'll send a patch in a minute which hopefully fixes that skipping the exit when using qtest and called without -bios.

pegasos2 works because there's a vof.bin for it in pc-bios/.

Now it has vof.bin but it did not have that previously and it still worked when it needed -bios too. But that was a while ago so don't remember the details.

Regards,
BALATON Zoltan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]