Re: [PATCH v7 0/3] Add emulation of AmigaOne XE board

[BALATON Zoltan]

On Tue, 7 Nov 2023, BALATON Zoltan wrote:
> On Tue, 7 Nov 2023, Daniel Henrique Barboza wrote:
> > On 11/7/23 14:33, BALATON Zoltan wrote:
> > > On Tue, 7 Nov 2023, Daniel Henrique Barboza wrote:
> > > > Zoltan,
> > > >
> > > > Gitlab is complaining about a missing file in one of the tests:
> > > >
> > > >
> > > >  8/259 qemu:qtest+qtest-ppc / qtest-ppc/test-hmp ERROR           0.22s   
> > > > killed by signal 6 SIGABRT
> > > > 4324>>> 
> > > > G_TEST_DBUS_DAEMON=/builds/danielhb/qemu/tests/dbus-vmstate-daemon.sh 
> > > > QTEST_QEMU_BINARY=./qemu-system-ppc MALLOC_PERTURB_=87 
> > > > PYTHON=/builds/danielhb/qemu/build/pyvenv/bin/python3 
> > > > /builds/danielhb/qemu/build/tests/qtest/test-hmp --tap -k
> > > > 4325――――――――――――――――――――――――――――――――――――― ✀ 
> > > > ―――――――――――――――――――――――――――――――――――――
> > > > 4326stderr:
> > > > 4327qemu-system-ppc: Could not find firmware 'u-boot-amigaone.bin'
> > > > 4328Broken pipe
> > > > 4329../tests/qtest/libqtest.c:195: kill_qemu() tried to terminate QEMU 
> > > > process but encountered exit status 1 (expected 0)
> > > > 4330(test program exited with status code -6)
> > > > 4331TAP parsing error: Too few tests run (expected 13, got 0)
> > > >
> > > >
> > > > You can reproduce it like this:
> > > >
> > > > $ make -j -C build  && QTEST_QEMU_BINARY=./build/qemu-system-ppc64 
> > > > ./build/tests/qtest/test-hmp
> > > >
> > > > I ended up amending in-tree (downloaded the firmware, put it under 
> > > > pc-bios, updated pc-bios/meson.build).
> > > > My manual test now passes, but not sure if gitlab will nag about it. 
> > > > Let's wait and see.
> > >
> > > This is handled in the avocado test and it should download the file from 
> > > the URL there. When tested locally it worked and downloaded the file and 
> > > extracted the firmware bin from it. Can the gitlab CI download stuff or 
> > > does it expect it to be in local cache already where you need to put it 
> > > somehow beforehand? I think Philippe said something about that before but 
> > > I did not quite get it as I don't know neither avocado nor gitlab. Hope 
> > > Philippe is reading it and can chime in.
> >
> > Gitlab CI can download stuff. But note that the error above is not avocado, 
> > it's hmp. It expects a firmware file to be available, and I'm not entirely 
> > sure it'll make any effort (e.g. downloading it) aside from checking if the 
> > file exists.
>
> Hmm, that's strange because the extracted firmware is passed with -bios in 
> the avocado test. But maybe it's then something else tries to run the machine 
> with some other parameters but it needs a firmware. I was told we can't add 
> the firmware because while it's GPL the sources were lost and not available 
> any more so we only have the binary. Then the question is which test is 
> trying to run the machine without -bios? What's test-hmp?

So if it's tests/qtest/test-hmp.c that seems to try to run a bunch of 
command for each machine AFAIU. This machine needs a firmware image but 
this test seems to run it with -S and never starts the machine so could 
take any file with -bios for that, e.g. -bios vof.bin (thought about -bios 
/dev/null but that does not work but any other file should probably be 
OK). I don't know how to tell test-hmp to use that thogh or to skip this 
machine.

At some point pegasos2 also needed a firmware but this wasn't a problem 
back then. Either this test is new or we could just ignore this error?

Regards,
BALATON Zoltan

> > > But the test is not required to run the machine so as a last resort you 
> > > could just drop the avocado patch and then we can add it later if we can't 
> > > figure this out now.
> >
> > Not sure if dropping the avocado test would remediate the situation, but 
> > noted.
> >
> > For now let's push stuff upstream. We have the freeze window to make 
> > smaller
> > adjustments if needed.
> >
> >
> > Thanks,
> >
> > Daniel
> >
> > > Regards,
> > > BALATON Zoltan
> > >
> > > > I told you: code freeze is a blast! Let's see if it's still sunny for the
> > > > AmigaOne XE board emulation.
> > > >
> > > >
> > > >
> > > > Thanks,
> > > >
> > > >
> > > > Daniel
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > On 10/27/23 08:54, BALATON Zoltan wrote:
> > > > > Changes in v7:
> > > > > - Increase default memory size to 512m to match pegasos2 and sam460ex
> > > > > and it's a better default for AmigaOS
> > > > >
> > > > > Changes in v6:
> > > > > - Dropped patch 1, now it's
> > > > >
> > > > > Based-on: <20231024224056.842607-1-mark.cave-ayland@ilande.co.uk>
> > > > >
> > > > > ([PATCH v2 0/3] ide: implement simple legacy/native mode switching for 
> > > > > PCI IDE controllers)
> > > > > - Added Tested-by from Rene
> > > > >
> > > > > Changes in v5:
> > > > > - Fixed avocado test
> > > > >
> > > > > Changes in v4:
> > > > > - Found typo in comment in patch 1 so ended up rewording it again
> > > > > trying to make it more concise. Also take the idea of using
> > > > > range_covers_byte from Mark's patch
> > > > > - Added RFC patch for avocado test (untested, I don't have Avocado)
> > > > >
> > > > > Changes in v3:
> > > > > - Update values, comment and commit message in patch 1 again
> > > > >
> > > > > Changes in v2:
> > > > > - Update comment and commit message in patch 1 (Mark)
> > > > > - Fix irq mapping in patch 2 (Volker)
> > > > >
> > > > > Regards,
> > > > > BALATON Zoltan
> > > > >
> > > > > BALATON Zoltan (3):
> > > > >    hw/pci-host: Add emulation of Mai Logic Articia S
> > > > >    hw/ppc: Add emulation of AmigaOne XE board
> > > > >    tests/avocado: Add test for amigaone board
> > > > >
> > > > >   MAINTAINERS                             |   8 +
> > > > >   configs/devices/ppc-softmmu/default.mak |   1 +
> > > > >   hw/pci-host/Kconfig                     |   5 +
> > > > >   hw/pci-host/articia.c                   | 293 ++++++++++++++++++++++++
> > > > >   hw/pci-host/meson.build                 |   2 +
> > > > >   hw/ppc/Kconfig                          |   7 +
> > > > >   hw/ppc/amigaone.c                       | 164 +++++++++++++
> > > > >   hw/ppc/meson.build                      |   2 +
> > > > >   include/hw/pci-host/articia.h           |  17 ++
> > > > >   tests/avocado/ppc_amiga.py              |  38 +++
> > > > >   10 files changed, 537 insertions(+)
> > > > >   create mode 100644 hw/pci-host/articia.c
> > > > >   create mode 100644 hw/ppc/amigaone.c
> > > > >   create mode 100644 include/hw/pci-host/articia.h
> > > > >   create mode 100644 tests/avocado/ppc_amiga.py